Entity relationships do not (always) validate 'primary' flag is accurate and doesn't hit the entity cache reliably

  • Thread starter Thread starter Xon
  • Start date Start date

Xon

Guest
Member
When 'primary' is set on a relationship, XF\Mvc\Entity\Manager::getRelation parses the condition into a key-value set to lookup by primary key the linked entity.

This has the following issues:
  • When this key-value has 1 entry, Finder::find => Finder::whereId do not validate this is a known primary key column (they only do this for an array).
  • For multi-column primary keys, the order is dependant on the list of conditions and not the primary key as defined in the...

Read more

Continue reading...
 
Top