XF\Mvc\Entity\Manager\getFinder does not reliably return the same type depending on class extensions

  • Thread starter Thread starter Xon
  • Start date Start date

Xon

Guest
Member
XenForo's dynamically creates finders of a given base-type if they are extended or otherwise will return a \XF\Mvc\Entity\Finder instance.

The problem is when return and parameter arguments are narrower than the \XF\Mvc\Entity\Finder and will cause a type error violation.
  • XenForo does not define XF\Finder\Warning
  • Add-on A extended XF\Finder\Warning
  • Add-on B has a return type hint of XF\Finder\Warning...

Read more

Continue reading...
 
You must log in or register to reply here.
Top